Profile pictures for users #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SekoiaTree
force-pushed
the
sk/pfp-ui-user
branch
from
29f323a to
ceffefa
Compare
ortolino
approved these changes
Jun 1, 2024
| { | ||
| CoroutineScope(Dispatchers.Main).launch { | ||
| _uiState.value.snackbarHostState.showSnackbar( | ||
| message = "Error loading profile picture", duration = SnackbarDuration.Short) |
There was a problem hiding this comment.
Maybe add specific error for when the image cannot be found?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262. This PR adds the ability to add and load profile pictures. If the image cannot be fetched, the default icon is displayed and an error is shown, but the page still loads, because it is not a core functionality.
Still needs to be done: refresh the profile picture on reload.