Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewmodel : members management #400

Merged
merged 15 commits into from
Jun 2, 2024
Merged

Conversation

Mai-LinhC
Copy link
Contributor

@Mai-LinhC Mai-LinhC commented Jun 2, 2024

closes #378

  • Remove the invitation (applicants) since it won't be done in V1
  • Dialog to edit member('s role)
  • Edit someone's role
  • Dialog to remove member from asso
  • Remove someone after confirmation
  • Test for edit
  • Test for delete

@Mai-LinhC Mai-LinhC linked an issue Jun 2, 2024 that may be closed by this pull request
3 tasks
@Mai-LinhC
Copy link
Contributor Author

  • Functionalities need some API functions that are not yet done
  • The dialogs open only after touching the screen ? Need to figure out why
  • The edit dialog looks wonky and the spacings look wrong, no idea why yet

@Mai-LinhC
Copy link
Contributor Author

  • Functionalities need some API functions that are not yet done
  • The dialogs open only after touching the screen ? Need to figure out why
  • The edit dialog looks wonky and the spacings look wrong, no idea why yet
  • waiting for API
  • the bug with the dialog is just on the emulator, works perfectly well on device
  • dialog looks fine on device, it's just list items

@Mai-LinhC Mai-LinhC marked this pull request as ready for review June 2, 2024 21:04
Copy link

sonarcloud bot commented Jun 2, 2024

Copy link
Contributor

@sarahbadr17 sarahbadr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug. I don't know if it's normal or not
photo_2024-06-02_23-32-40
When Selecting Associfiy as a member I couldn't change its role

Copy link
Contributor

@sarahbadr17 sarahbadr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be normal after second thought

@Mai-LinhC
Copy link
Contributor Author

Seems to be normal after second thought

I can't reproduce the bug at all, but seeing the snackbar it's an API fail, so it should be fine

@Mai-LinhC Mai-LinhC merged commit 2f0f590 into main Jun 2, 2024
3 checks passed
@Mai-LinhC Mai-LinhC deleted the mc/378-vm-members-management branch June 2, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VM members management
3 participants