Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick task location #405

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Pick task location #405

merged 12 commits into from
Jun 2, 2024

Conversation

Polymeth
Copy link
Contributor

@Polymeth Polymeth commented Jun 2, 2024

The map can display markers however there was no way to select a marker while creating an event, so this PR adds a map picker in Create Event menu.

Will need to add one on Edit Event later on.

This PR addresses #201.

@Polymeth Polymeth marked this pull request as ready for review June 2, 2024 14:47
Copy link
Contributor

@sarahbadr17 sarahbadr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some few comments to remove otherwise very good! It works well on my phone! Good job I know it wasn't easy :)

Copy link
Contributor

@sarahbadr17 sarahbadr17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible job! Worthy of a senior programmer

Copy link

sonarcloud bot commented Jun 2, 2024

@Polymeth Polymeth merged commit b844d2a into main Jun 2, 2024
3 checks passed
@Polymeth Polymeth linked an issue Jun 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick task location
2 participants