-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick task location #405
Pick task location #405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some few comments to remove otherwise very good! It works well on my phone! Good job I know it wasn't easy :)
app/src/main/java/com/github/se/assocify/ui/screens/event/tasktab/task/TaskScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/se/assocify/ui/screens/event/tasktab/task/TaskScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/se/assocify/ui/screens/event/tasktab/task/TaskViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/se/assocify/ui/screens/event/tasktab/task/TaskViewModel.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible job! Worthy of a senior programmer
Quality Gate passedIssues Measures |
The map can display markers however there was no way to select a marker while creating an event, so this PR adds a map picker in Create Event menu.
Will need to add one on Edit Event later on.
This PR addresses #201.