Text will no longer return the placeholder #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wolframhaussig
commented
Feb 26, 2024
wolframhaussig
commented
- instead of relying on the OOTB drawing and missusing the Text property, we custom draw the hint now
- removed Hint and all hint-related code as we are now using the OOTB property PlaceholderText
- removed TextForeColor as we can use ForeColor as usual again
- renamed HintForeColor to PlaceHolderForeColor to align with PlaceholderText
- instead of relying on the OOTB drawing and missusing the Text property, we custom draw the hint now - removed Hint and all hint-related code as we are now using the OOTB property PlaceholderText - removed TextForeColor as we can use ForeColor as usual again - renamed HintForeColor to PlaceHolderForeColor to align with PlaceholderText
Nockiro
requested changes
Feb 26, 2024
StylableWinFormsControls/StylableWinFormsControls/Controls/StylableTextBox.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Robin Freund <[email protected]> Signed-off-by: wolframhaussig <[email protected]>
…se of PlaceholderText
…-return-the-hint-when-no-text-is-entered Signed-off-by: Robin Freund <[email protected]>
Nockiro
reviewed
Feb 27, 2024
Signed-off-by: Robin Freund <[email protected]>
Nockiro
approved these changes
Feb 27, 2024
Nockiro
deleted the
bug/59-bug-accessing-stylabletextboxtext-may-return-the-hint-when-no-text-is-entered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.