Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gymnasium client #18
Add Gymnasium client #18
Changes from 4 commits
26f0d23
be27afd
3c9ac52
09b99aa
1e8d03a
d9a9b44
cfe0958
13b3d01
9218ddb
b18fb18
a0ac991
ecd7e47
0d76a01
bdfb2d3
ec16498
5686a52
441bc23
1cb167a
8b7dfa7
eafe572
a5a49f5
4020a3a
95ef2c5
1ac7db9
7614ef3
5526ad7
1f8bfae
ee799ae
48e7d2a
81fbf35
4624f71
7c22a47
4fd2947
8b1ddce
524bc3e
4fe0eb5
d18eec2
ada76bb
7f90675
becd62b
02071a6
21e9ea6
e4abb75
bfe6332
c3b69f7
e5e7a31
bbbe3f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one also seems better to use CMake since we don't expect to modify it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use CMake to fetch these instead?
An example from a CMakeLists.txt file I wrote for something else:
I don't have a lot experience with it but it seems maybe better if we don't expect users to edit the source of these at all. I guess at least for SDL we don't expect to edit it at all. irrlictmt maybe we will need to edit it?
Thoughts?