Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology updates #77

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Ontology updates #77

merged 8 commits into from
Oct 17, 2024

Conversation

paluchasz
Copy link
Collaborator

@paluchasz paluchasz commented Oct 16, 2024

  • New ontology updates
  • Some fixes to KRT
  • Fix and tests added for CombinatorialSynonymGenerator
    See individual commits for details

@paluchasz paluchasz marked this pull request as ready for review October 16, 2024 15:24
@paluchasz paluchasz requested a review from RichJackson October 16, 2024 15:24
@paluchasz
Copy link
Collaborator Author

integration tests passed https://github.com/AstraZeneca/KAZU/actions/runs/11369065257

Copy link
Contributor

@RichJackson RichJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion to rename the cached method (since it's no longer cached!)

@paluchasz paluchasz requested a review from RichJackson October 17, 2024 12:06
@paluchasz paluchasz merged commit 8e09ece into main Oct 17, 2024
2 checks passed
@paluchasz paluchasz deleted the ontology_updates branch October 17, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants