Add TurnToAngle #21
Open
Add TurnToAngle #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frc6897
added
subsytem:drive
siddhxrth
approved these changes
Aug 21, 2022
jgoldberger26
requested changes
Aug 21, 2022
There was a problem hiding this comment.
After output is clamped, this is ready to be tested and then merged.
However, try and keep commits as relevant as possible. For example, many lines of code have been unnecessarily formatted, m_crossButton should have been changed in a refactoring issue, and fixing the field image should have been given its own issue. This will eventually lead to merge conflicts if everything is not kept isolated.
jgoldberger26
approved these changes
Aug 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Robot go brrrrrrrrrrr
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13. Added a
TurnToAnglecommand which turns the robot to the specified angle. Useful for autonomous routines where tight turns are needed.Edit 9-23-22: Added NITRO button! It's set as triangle. Resolves #9.