Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location-proof-protocol-comments-AST-187 #104

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ronerlih
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.65%. Comparing base (5c3114c) to head (7803525).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files           6        6           
  Lines         152      152           
  Branches       41       41           
=======================================
  Hits          115      115           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


# 📍 Location Proof Protocol

The Location Proof Protocol aims to address the challenge of proving location on the decentralized web in a flexible, yet standardized way.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Location Proof Protocol aims to address the challenge of proving location on the decentralized web in a flexible, yet standardized way.
The Location Proof Protocol aims to address the challenge of proving location on the web, using the decentralized web in a flexible, yet standardized way.

..along those lines, to laminate that the problem is not only on web3, but it's a general problem on the internet, still, maybe just distracts focus, whatever is best.

Comment on lines +11 to +12
Given the diverse requirements and approaches for location proofs, our goal is to support innovation across a wide range of proof strategies
while providing a standard data model for creating and verifying these proofs.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given the diverse requirements and approaches for location proofs, our goal is to support innovation across a wide range of proof strategies
while providing a standard data model for creating and verifying these proofs.
Given the diverse requirements and approaches for location proofs, our goal is to support innovation across a wide range of proof strategies, while providing a standard data model for creating and verifying these proofs.


## The Challenge

### Broad Approaches to Location Proofs
Copy link
Contributor Author

@ronerlih ronerlih Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Broad Approaches to Location Proofs
### Broad classifications of Location Proof strategies

?

Comment on lines +29 to +30
- **Sensor Data Strategies**: Where devices sense local networks, environmental conditions, images + audio, accelerometers, etc, and
location is discerned from analysis of this evidence. i.e. radio frequency / optical / inertial / acoustic / magnetometer localization
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be combined with "Near-field"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see them as different — Near-field is an active scan of another device, sensor data is picking up ambient measurements of the physical and digital environment

- **Cryptographic Schemes**: Zero-knowledge proofs verified on-chain or in peer nodes.
- **AI-based Schemes**: Analyzing photos or contextual information.
- **Economic Schemes**: Requires payment or staking value for proof creation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an addition, along the lines of,
we plan to support these schemas, and others created according to need, with the same recipe interface to adhear to, and to be unoppinionated about the payload (Array<bytes>) for the verifier method.
(maybe to details for this context).

- **Time-based Schemes**: Involves waiting or challenge periods.
- **Cryptographic Schemes**: Zero-knowledge proofs verified on-chain or in peer nodes.
- **AI-based Schemes**: Analyzing photos or contextual information.
- **Economic Schemes**: Requires payment or staking value for proof creation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And perhaps with Adam's suggestion, a gasless view function to be called on need.

Comment on lines +58 to +59
We are developing a protocol that accommodates various proof strategies while maintaining a standard data model and tools for creating and
verifying location proofs.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We are developing a protocol that accommodates various proof strategies while maintaining a standard data model and tools for creating and
verifying location proofs.
We are developing a protocol that accommodates various proof strategies while maintaining a standard data model and tools for creating and verifying location proofs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(probably prettier, then somehow I have other config.. tbd :)


## Repository Contents

- **Contract Deployment Scripts**: Scripts to deploy the core EAS schema for the Location Proof Protocol
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to setup a link to tree, or just links, or a .md table ?
Or the table you set up on notion?

├── package.json
├── remappings.txt
├── script
│   ├── Base.s.sol
│   └── Deploy.s.sol
├── src
│   ├── contracts
│   └── interface
└── test
    └── RegistryFactory.t.sol


## Core Schema v0.1 (Sepolia Testnet)

The current working schema described [here](./schema/README.md) is deployed on Ethereum Sepolia testnet, UID
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe still best to add teh schema fields here

Copy link
Contributor Author

@ronerlih ronerlih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Great work @johnx25bd !!
I'd added comments, more in the spirit of thinking of this out laud.
Approved as is from my side, for your consideration.

@johnx25bd johnx25bd changed the title Location-proff-protocol-comments-AST-187 location-proof-protocol-comments-AST-187 Jun 14, 2024
@johnx25bd johnx25bd merged commit 1c13e13 into main Jun 18, 2024
6 checks passed
@ronerlih ronerlih deleted the location-proof-protocol-review branch June 23, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants