Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(julia): JuliaActivateEnv merged upstream #1353

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Feb 4, 2025

📑 Description

I got this user command merged upstream to nvim-lspconfig totally forgot to open a PR for this branch months ago 😅 Now is the time haha

Upstream PR: neovim/nvim-lspconfig#3318

ℹ Additional Information

Copy link

github-actions bot commented Feb 4, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Feb 4, 2025

@mehalter Got a link to the PR that fixes this? Just for the sake of having it here.

@mehalter
Copy link
Member Author

mehalter commented Feb 4, 2025

@Uzaaft updated the original PR body to include it

@Uzaaft Uzaaft merged commit 4d8d634 into main Feb 4, 2025
25 checks passed
@Uzaaft Uzaaft deleted the julia_refactor branch February 4, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants