feat: disable DisplayEnhancementService on desktops

Atlas-OS · Sep 18, 2023 · a927ae0 · a927ae0
1 parent f2e07fa
commit a927ae0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/src/playbook/Configuration/atlas/services.yml b/src/playbook/Configuration/atlas/services.yml
@@ -75,7 +75,6 @@ actions:
   # DsSvc 4 < can cause issues with Snip & Sketch
   # icssvc 4 < breaks mobile/Wi-Fi hotspot
   # IKEEXT 4 < causes Teredo not to work
-  # DisplayEnhancementService 4 < breaks brightness slider on laptops
   # iphlpsvc 4 < causes Teredo not to work
   # KeyIso 4 < causes issues with NVCleanstall's driver telemetry tweak
   # SharedAccess 4 < breaks mobile/Wi-Fi hotspot

diff --git a/...ook/Executables/AtlasDesktop/3. Configuration/Power/Power Saving/Disable Power Saving.cmd b/...ook/Executables/AtlasDesktop/3. Configuration/Power/Power Saving/Disable Power Saving.cmd
@@ -13,7 +13,7 @@ for /f "delims=:{}" %%a in ('wmic path Win32_SystemEnclosure get ChassisTypes ^|
 set "DEVICE_TYPE=PC"
 for %%a in (8 9 10 11 12 13 14 18 21 30 31 32) do if "!CHASSIS!" == "%%a" (set "DEVICE_TYPE=LAPTOP")
 
-if "%DEVICE_TYPE"=="LAPTOP" (
+if "!DEVICE_TYPE!"=="LAPTOP" (
     echo WARNING: You are on a laptop, disabling power saving features will cause faster battery drainage and increased heat output.
     echo          If you use your laptop on battery, certain power saving features will enable, but not all.
     echo          It's NOT recommended to disable power saving on laptops in general.

diff --git a/src/playbook/Executables/FINALIZE.cmd b/src/playbook/Executables/FINALIZE.cmd
@@ -220,3 +220,13 @@ if "!diskDrive!" == "SSD" (
     rem Disable SysMain (Superfetch and Prefetch)
     reg add "HKLM\SYSTEM\CurrentControlSet\Services\SysMain" /v "Start" /t REG_DWORD /d "4" /f > nul
 )
+
+:: Detect if user uses laptop device or personal computer
+for /f "delims=:{}" %%a in ('wmic path Win32_SystemEnclosure get ChassisTypes ^| findstr [0-9]') do set "CHASSIS=%%a"]
+set "DEVICE_TYPE=PC"
+for %%a in (8 9 10 11 12 13 14 18 21 30 31 32) do if "!CHASSIS!" == "%%a" (set "DEVICE_TYPE=LAPTOP")
+
+:: Disable laptop-related services on PC
+if "!DEVICE_TYPE!"=="PC" (
+    call %windir%\AtlasModules\Scripts\setSvc.cmd DisplayEnhancementService 4
+)
diff --git a/src/playbook/playbook.conf b/src/playbook/playbook.conf
@@ -70,7 +70,7 @@
 			</Options>
 			<BottomLine Text="Learn more" Link="https://docs.atlasos.net/getting-started/post-installation/security/#core-isolation"/>
 		</RadioPage>
-		<CheckboxPage IsRequired="true" Description="Select the miscellaneous options that you would like to use, which you can change later.">
+		<CheckboxPage IsRequired="true" Description="Select the miscellaneous options you would like to use, which you can change later.">
 			<Options>
 				<CheckboxOption>
 					<Text>Remove Microsoft Edge</Text>