Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor Playbook options #1111

Merged
merged 3 commits into from
Jun 2, 2024
Merged

feat: refactor Playbook options #1111

merged 3 commits into from
Jun 2, 2024

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Jun 1, 2024

  • The page related to services has been removed
    • Many users go through the options without reading
    • This leads to them disabling functionality that they then can't re-enable in the usual ways in Windows, which causes confusion
    • This is all for a very negligible performance boost
    • Disabling notifications is a security risk as users can't get update notifications
  • Auto-updates and core isolation have swapped places
    • Auto-updates is now a radio page and provides more info on updates
    • Info on core isolation is arguably less critical than info on auto-updates
  • Mitigations has had its TopLine (the grey text underneath) swapped with the description
    • This is to make users more aware of the negative impact on modern CPUs

@he3als he3als changed the base branch from main to dev June 1, 2024 19:11
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Jun 1, 2024
@he3als
Copy link
Contributor Author

he3als commented Jun 1, 2024

This is what it looks like now:

vmware_2pVLQflRTr.mp4

@he3als he3als mentioned this pull request Jun 1, 2024
Closed
RadNotRed
RadNotRed approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RadNotRed RadNotRed merged commit 80e2329 into dev Jun 2, 2024
3 checks passed
@RadNotRed RadNotRed deleted the new-playbook-options branch June 2, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-P1neapple the-P1neapple the-P1neapple approved these changes

@RadNotRed RadNotRed RadNotRed approved these changes

@LumiFae LumiFae Awaiting requested review from LumiFae

@jacksyrm jacksyrm Awaiting requested review from jacksyrm

@Xyueta Xyueta Awaiting requested review from Xyueta

Assignees
No one assigned
Labels
playbook Playbook related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@he3als @RadNotRed @the-P1neapple