Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOFTWARE.ps1: Fix VLC Download #988

Merged
merged 1 commit into from
Dec 11, 2023
Merged

SOFTWARE.ps1: Fix VLC Download #988

merged 1 commit into from
Dec 11, 2023

Conversation

Kajal4414
Copy link
Contributor

@Kajal4414 Kajal4414 commented Dec 11, 2023

Questions

Note: You should commit directly to main for translations of the README.md.

Describe your pull request

Fixes this error:

Err

@github-actions github-actions bot added the playbook Playbook related issues/PRs label Dec 11, 2023
@Ast3risk-ops
Copy link

Ast3risk-ops commented Dec 11, 2023

Invalid description: the download link is unchanged.

What does this PR actually do.

@Kajal4414
Copy link
Contributor Author

Invalid description: the download link is unchanged.

What does this PR actually do.

The original code giving this error:

Err

I know I can modify the Invoke-WebRequest line to include the -UseBasicParsing parameter to avoid using the Internet Explorer engine. However, I believe the updated lines are better.

@Ast3risk-ops
Copy link

Ast3risk-ops commented Dec 11, 2023

Invalid description: the download link is unchanged.
What does this PR actually do.

The original code giving this error:

Err

I know I can modify the Invoke-WebRequest line to include the -UseBasicParsing parameter to avoid using the Internet Explorer engine. However, I believe the updated lines are better.

Put that under PR description (minus my quote) in your PR (go to the first message > 3 dots > edit)

@he3als
Copy link
Contributor

he3als commented Dec 11, 2023

Thank you! We'll also implement native ARM64 detection for these applications.

@he3als he3als merged commit 8d65a8d into Atlas-OS:dev Dec 11, 2023
1 check passed
@Kajal4414
Copy link
Contributor Author

Thank you! We'll also implement native ARM64 detection for these applications.

NP :)
Please review this: https://github.com/sakshiagrwal/Atlas/commit/9d6598ed18b367fdd62e1c22b36b2594042d0a99. If it's okay, I'll update the apps and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants