Fix for wrong name matches when rank is filled #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered recently that some species are incorrectly matched when the
rankis filled in the occurrence and correctly matched when it's not.More info in:
https://atlaslivingaustralia.slack.com/archives/CCTFGEU1G/p1719471737011039
Also described in:
AtlasOfLivingAustralia/Taxonomic-Issues-Register_new#161
More than the simple
Eucalyptustest included in this PR, I did a new tool inside thela-toolkitto compare some random occurrences in a LA portal against the equivalent occurrences in GBIF.org.Testing ~400 occurrences of our ~50M records with an
ala-namematching-servicewithout patching:and with an
ala-namematching-serviceusing this patch:And the last report of issues:
https://datos.gbif.es/others/202407120244_la_gbif_comparative_issues_report.html
As you can see that the number of differences and nulls in the scientificNames are significantly lower.
This comparative tool will help us also to debug aligning issues in
pipelines.