Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions to use libpcre2 #661

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

ryfactor
Copy link
Member

No description provided.

@ryfactor ryfactor marked this pull request as draft January 24, 2025 02:57
@ryfactor
Copy link
Member Author

I guess the scope of this has increased to updating the code that uses pcre's functions to however pcre2 does it. I'll take a look this weekend hopefully with a solution, unless someone else beats me to it.

No idea if this runs stably...
@ryfactor
Copy link
Member Author

Now the vm cannot find libpng. I guess I better update that next.

@ryfactor
Copy link
Member Author

GNU 13.3 now throwing this error:

In file included from /home/runner/work/ivan/ivan/FeLib/Include/config.h:18,
                 from /home/runner/work/ivan/ivan/FeLib/Source/config.cpp:13:
In copy constructor ‘festring::festring(cfestring&)’,
    inlined from ‘festringpile::festringpile(cfestring&)’ at /home/runner/work/ivan/ivan/FeLib/Include/festring.h:145:37,
    inlined from ‘festringpile operator+(cfestring&, type) [with type = const char*]’ at /home/runner/work/ivan/ivan/FeLib/Include/festring.h:159:10,
    inlined from ‘static truth configsystem::NormalStringChangeInterface(stringoption*)’ at /home/runner/work/ivan/ivan/FeLib/Source/config.cpp:[23](https://github.com/Attnam/ivan/actions/runs/13045884947/job/36396279429?pr=661#step:6:24)7:31:
/home/runner/work/ivan/ivan/FeLib/Include/festring.h:172:7: error: writing 8 bytes into a region of size 0 [-Werror=stringop-overflow=]
  172 |       ++REFS(Data);

@ryfactor
Copy link
Member Author

GNU 13.3 now throwing this error:
...

I was unable to reproduce this error in a devcontainer running ubuntu-24.04 with GNU 13.3.0.

GitHub must have shipped a bugged compiler with their ubuntu-latest runner, or I don't know what they've done. Furthermore, devcontainers and runners are not the same beast, making it very inconvenient to reproduce the same errors. So much for solving the "works on my (virtual) machine" issue.

FeLib/Source/sfx.cpp Fixed Show fixed Hide fixed
FeLib/Source/sfx.cpp Fixed Show fixed Hide fixed
FeLib/Source/sfx.cpp Fixed Show fixed Hide fixed
FeLib/Source/sfx.cpp Fixed Show fixed Hide fixed
Main/Source/message.cpp Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant