Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: python 3.12 support #319

Merged
merged 4 commits into from
Jan 24, 2024
Merged

chore: python 3.12 support #319

merged 4 commits into from
Jan 24, 2024

Conversation

ddkasa
Copy link
Contributor

@ddkasa ddkasa commented Jan 24, 2024

Closes #318

Unit tests were passing and local CLI installation was working, but integration test failed with 410(Gone) responses. I am assuming that's due to the v8 deprecation, but I think you already have a fix in the works for that.

@ddkasa ddkasa closed this Jan 24, 2024
@ddkasa ddkasa reopened this Jan 24, 2024
Copy link
Owner

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great! Thanks for the PR 👍

@AuHau AuHau changed the title Python 3.12 support chore: python 3.12 support Jan 24, 2024
@AuHau AuHau merged commit 6f22556 into AuHau:master Jan 24, 2024
0 of 5 checks passed
@AuHau
Copy link
Owner

AuHau commented Jan 24, 2024

I will try to find some time and finish the API v9 migration and then release it together with your changes as those both are breaking changes... But can't promise any timeline 🙈

@ddkasa ddkasa deleted the py3.12-support branch January 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 Support
2 participants