Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add requirements to run tests #322

Closed
wants to merge 4 commits into from

Conversation

theletterjeff
Copy link
Contributor

Integration tests have not been running on contributors' machines due to missing dependencies from the requirements.txt file. This PR adds the four missing test dependencies.

@AuHau
Copy link
Owner

AuHau commented May 28, 2024

Check out the Contributor guideline 😉

https://github.com/AuHau/toggl-cli/blob/master/CONTRIBUTING.md

There it is stated that you need to install different target for the test dependencies.

But that said it could be improved with adding that you can also install it with pip install -r test-requirements.txt

@AuHau
Copy link
Owner

AuHau commented May 29, 2024

Thanks for the PR, but the distinction between testing dependencies and runtime dependencies is there for a reason, so I won't merge this.

@AuHau AuHau closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants