Prevent concurrent crud sweeps and add proper cleanup #10865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRUD sweep mechanism was running more frequently than intended due to lack of proper goroutine management. This commit: - Adds mutex protection to prevent concurrent sweeps - Implements proper goroutine cleanup with stop channels - Adds sync.Once to prevent multiple starts/stops - Adds proper resource cleanup on shutdown - Stagger initial sweeps to prevent thundering herd This should reduce the load on /internal/crud/sweep endpoints
|
endline
requested review from
stereosteve
and removed request for
stereosteve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CRUD sweep mechanism was running more frequently than intended due to lack of proper goroutine management.
This should reduce the load on
/internal/crud/sweependpoints.