Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-5729] Improve listening-history page, Add track-table-lineup #11207

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

dylanjeffers
Copy link
Contributor

Description

  • Improves listening-history-page by removing provider pattern and adding track-table-lineup
  • Adds track-table-lineup component similar to tan-query-lineup, to make it much easier to work with track-lineups and tables.
  • Simplifies Table and TracksTable components to spread props.

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 5e58f60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylanjeffers dylanjeffers changed the base branch from main to feature-tan-query January 31, 2025 00:21
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang. Looks great!

Ty for making the reusable structure for it

const HistoryPage = ({ title, description }: HistoryPageProps) => {
const { lineup, isInitialLoading, data, isPlaying, togglePlay } =
useTrackHistory({
pageSize: 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: const PAGE_SIZE

Comment on lines -163 to -166
const debouncedFetchMore = useMemo(
() => (fetchMore ? debounce(fetchMore, 0) : null),
[fetchMore]
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these changes break existing stuff thats not moved over yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that i can tell, but will do more verification

@@ -0,0 +1,163 @@
import { useCallback, useMemo } from 'react'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nice to get new components going

totalRowCount,
pageSize
}: HistoryPageProps) => {
const pageSize = 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: caps case for a constant

Suggested change
const pageSize = 50
const PAGE_SIZE = 50

Copy link
Contributor

@DejayJD DejayJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new component, this is looking good

@dylanjeffers dylanjeffers merged commit 1d1da98 into feature-tan-query Jan 31, 2025
3 of 5 checks passed
@dylanjeffers dylanjeffers deleted the improve-lineup-table branch January 31, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants