-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-5729] Improve listening-history page, Add track-table-lineup #11207
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang. Looks great!
Ty for making the reusable structure for it
const HistoryPage = ({ title, description }: HistoryPageProps) => { | ||
const { lineup, isInitialLoading, data, isPlaying, togglePlay } = | ||
useTrackHistory({ | ||
pageSize: 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: const PAGE_SIZE
const debouncedFetchMore = useMemo( | ||
() => (fetchMore ? debounce(fetchMore, 0) : null), | ||
[fetchMore] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do these changes break existing stuff thats not moved over yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that i can tell, but will do more verification
@@ -0,0 +1,163 @@ | |||
import { useCallback, useMemo } from 'react' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so nice to get new components going
totalRowCount, | ||
pageSize | ||
}: HistoryPageProps) => { | ||
const pageSize = 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: caps case for a constant
const pageSize = 50 | |
const PAGE_SIZE = 50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the new component, this is looking good
Description