Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Dock icon on Mac OS X Sequoia du jour #772

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

domq
Copy link

@domq domq commented Dec 28, 2024

Fixes #771

  • gradlew run: add more compatibiity bugware on the JVM command line, as found on StackOverflow
  • Splice setupMacDockIcon() (which still works) out of setupMacMenus() (which doesn't)

Dominique Quatravaux added 3 commits December 28, 2024 17:02
Fixes

```
java.lang.IllegalAccessException: class org.jdesktop.application.utils.OSXAdapter cannot access class com.apple.eawt.Application (in module java.desktop) because module java.desktop does not export com.apple.eawt to unnamed module @30a3107a
```
That part still works on Sequoia 15.1.1 (24B91), despite https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-97C1D0BB-D5D3-4CAD-B17D-03A87A0AAF3B ; while the menu part doesn't anymore.
@domq domq force-pushed the fix/dock-icon-on-mac branch from ad31ff7 to e9b85f4 Compare December 28, 2024 16:33
@hbitteur
Copy link
Contributor

@domq
I personally have no access to a Mac, so I can't really review your modifications.
I'm blindly accepting your PR to the development branch

@hbitteur hbitteur merged commit f603e7d into Audiveris:development Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants