Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json & XML Dbcodecs #49

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Json & XML Dbcodecs #49

merged 10 commits into from
Nov 13, 2024

Conversation

AugustNagro
Copy link
Owner

Resolves #27

@AugustNagro AugustNagro changed the title WIP: Json dbcodec Json & XML Dbcodecs Oct 13, 2024
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@guizmaii guizmaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a comment you're free to ignore as it can be more complicated to implement: https://github.com/AugustNagro/magnum/pull/49/files#r1807555435

Otherwise, I like the approach :)

@AugustNagro
Copy link
Owner Author

Thanks for the review @guizmaii . It's a very interesting suggestion to use https://blog.7mind.io/no-more-orphans , I like the idea a lot.

I wonder can we merge these codecs as-is, and then experiment with adding the Optional codecs per https://blog.7mind.io/no-more-orphans in a new MR? I want to make sure I fully understand the implications.

@AugustNagro AugustNagro merged commit dc83b52 into master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Json & XML Column Deserialization
2 participants