Merge pull request LibreBooking#48 from apfelchips/develop

added API documentation / other stuff
AurimasF · May 18, 2021 · ed7cc4f · ed7cc4f
2 parents 1b36c3b + e7da1aa
commit ed7cc4f
Show file tree

Hide file tree

Showing 4 changed files with 2,475 additions and 32 deletions.
diff --git a/Pages/Page.php b/Pages/Page.php
@@ -451,29 +451,31 @@ private function ShouldShowNewVersion()
             return false;
         }
 
-        $newVersion = $this->server->GetCookie('new_version');
-        if (empty($newVersion)) {
-            $cookie = sprintf('v=%s,fs=%s', Configuration::VERSION, Date::Now()->Timestamp());
-            $this->server->SetCookie(new Cookie('new_version', $cookie));
-            return true;
-        }
-
-        $parts = explode(',', $newVersion);
-        $versionParts = explode('=', $parts[0]);
-        $firstShownParts = explode('=', $parts[1]);
-
-        if ($versionParts[1] != Configuration::VERSION)
-        {
-            $cookie = sprintf('v=%s,fs=%s', Configuration::VERSION, Date::Now()->Timestamp());
-            $this->server->SetCookie(new Cookie('new_version', $cookie));
-            return true;
-        }
-
-        if (Date::Now()->AddDays(-3)->Timestamp() > $firstShownParts[1])
-        {
-            return false;
-        }
-
-        return true;
+        // $newVersion = $this->server->GetCookie('new_version');
+        // if (empty($newVersion)) {
+        //     $cookie = sprintf('v=%s,fs=%s', Configuration::VERSION, Date::Now()->Timestamp());
+        //     $this->server->SetCookie(new Cookie('new_version', $cookie));
+        //     return true;
+        // }
+
+        // $parts = explode(',', $newVersion);
+        // $versionParts = explode('=', $parts[0]);
+        // $firstShownParts = explode('=', $parts[1]);
+
+        // if ($versionParts[1] != Configuration::VERSION)
+        // {
+        //     $cookie = sprintf('v=%s,fs=%s', Configuration::VERSION, Date::Now()->Timestamp());
+        //     $this->server->SetCookie(new Cookie('new_version', $cookie));
+        //     return true;
+        // }
+
+        // if (Date::Now()->AddDays(-3)->Timestamp() > $firstShownParts[1])
+        // {
+        //     return false;
+        // }
+
+        // TODO Actually check for new versions on git / save install date to DB.
+        // The old Method doesn't work when deleting cookies and confuses the users.
+        return false;
     }
 }