Fix Widget/MarkdownPreview/EditPencil spacing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
padding-and-edit-button-styling
branch
4 times, most recently
from
3c72361 to
2c1aed8
Compare
* Remove top padding from various `MarkdownPreview` elements, to avoid too much padding appearing at top of widget * Tighten coupling between EditButton and IconPencil, since the height and width of the button need to match the height and width of the svg (at least with current styling approach) * Remove IconPencil as a general-use import * Remove unused pencil.svg file * Make EditButton styles more generic, and override them inside the Widget component with behavior that's specific to Widget's use of the component * Make images expand to full width of widget, rather than 95%
chadoh
force-pushed
the
padding-and-edit-button-styling
branch
from
2c1aed8 to
4e55344
Compare
ottodevs
approved these changes
Jun 17, 2019
|
I took the freedom to push a tiny commit that fixes travis build, so it should be ready to merge now |
|
Thanks, Otto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
MarkdownPreviewelements, to avoidtoo much padding appearing at top of widget
and width of the button need to match the height and width of the svg
(at least with current styling approach)
Widget component with behavior that's specific to Widget's use of the
component
Screenshots