Implement block timestamp helper functions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topocount
force-pushed
the
feat/blockTime
branch
from
a041eb7 to
b2a0bc5
Compare
topocount
force-pushed
the
feat/blockTime
branch
from
b2a0bc5 to
22cbe9a
Compare
- add blockTime helper to get a block's timestamp or estimated mining date - implement a boolean helper that allows for different language depending on whether the block in question has been mined or not.
topocount
force-pushed
the
feat/blockTime
branch
from
22cbe9a to
22b2642
Compare
- remove any calls to `eth_blockNumber` - add date-fns format helper and expose formatting externally - move `isBlockMined` to a separate file - re-alphabetize import and exports in index.js - utilize regex tests for the future blocktime test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date
depending on whether the block in question has been mined or not.