Send a message directly on NetworkRuntime #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a means to send a message directly on a network runtime without need for a connection object.
Quoting Thomas here as I initially forgot about this change and had it lumped into another PR
Generally I agree with you, and what I'm doing here is definitely not the preferred use. However, we have a program where the majority of the MAVLink messaging is done by a third-party autonomy engine (a completely separate piece of hardware on the network). But in case the user wants to do direct manual control from our GCS, we have a way to tell the autonomy engine to open a link to the vehicle and we can send out manual control messages (technically it'll forward any message, but manual control is the intended use). The link basically operates as a repeater and its only one way, so we don't get any data back. This means no heartbeats, and a Connection is useless because it will time out for lack of heartbeats.
Open to exploring other way to solve this problem if you have suggestions, but this seemed the simplest to me.