Skip to content

Commit

Permalink
fix(s3stream): catch storage callback exception
Browse files Browse the repository at this point in the history
Signed-off-by: Robin Han <[email protected]>
  • Loading branch information
superhx committed Dec 15, 2023
1 parent 848cdde commit 12a779b
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions s3stream/src/main/java/com/automq/stream/s3/S3Storage.java
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
import java.util.stream.Collectors;
import java.util.stream.IntStream;

import static com.automq.stream.utils.FutureUtil.suppress;


public class S3Storage implements Storage {
private static final Logger LOGGER = LoggerFactory.getLogger(S3Storage.class);
Expand Down Expand Up @@ -426,6 +428,10 @@ private void handleAppendRequest(WalWriteRequest request) {
}

private void handleAppendCallback(WalWriteRequest request) {
suppress(() -> handleAppendCallback0(request), LOGGER);
}

private void handleAppendCallback0(WalWriteRequest request) {
TimerUtil timer = new TimerUtil();
List<WalWriteRequest> waitingAckRequests;
Lock lock = getStreamCallbackLock(request.record.getStreamId());
Expand Down

0 comments on commit 12a779b

Please sign in to comment.