Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): implement MemoryMetadataManager #854

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (504ed6d) 55.03% compared to head (f653b0d) 55.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #854      +/-   ##
============================================
- Coverage     55.03%   55.01%   -0.03%     
+ Complexity     1246     1244       -2     
============================================
  Files           132      132              
  Lines          8531     8531              
  Branches        789      789              
============================================
- Hits           4695     4693       -2     
  Misses         3422     3422              
- Partials        414      416       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.75% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx
Copy link
Contributor

superhx commented Dec 26, 2023

It is recommended to add strong verification of correctness. You can refer to https://github.com/AutoMQ/automq-for-kafka/blob/develop/metadata/src/main/java/org/apache/kafka/controller/stream/StreamControlManager.java

@superhx superhx enabled auto-merge (squash) December 26, 2023 09:04
@superhx superhx merged commit 59716a7 into main Dec 26, 2023
13 checks passed
@superhx superhx deleted the memory_metadata branch December 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants