Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): delete out-dated object directly during compaction #896

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Jan 15, 2024

No description provided.

@SCNieh SCNieh requested a review from superhx January 15, 2024 11:57
@SCNieh
Copy link
Contributor Author

SCNieh commented Jan 15, 2024

#897

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d31f48) 55.00% compared to head (f1fac81) 55.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #896   +/-   ##
=========================================
  Coverage     55.00%   55.00%           
+ Complexity     1246     1245    -1     
=========================================
  Files           133      133           
  Lines          8534     8534           
  Branches        789      789           
=========================================
  Hits           4694     4694           
  Misses         3425     3425           
  Partials        415      415           
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.60% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

@superhx superhx merged commit 315ec49 into main Jan 15, 2024
7 checks passed
@superhx superhx deleted the compaction branch January 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants