Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(s3stream): create S3Operator with credential providers #898

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

@Chillax-0v0
Copy link
Contributor Author

TODO: fix dependencies on s3operator in RocketMQ

@Chillax-0v0 Chillax-0v0 force-pushed the refactor-s3-operator-credentail-provider branch from dc789cc to ed5e707 Compare January 18, 2024 08:30
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (cf07ae3) 54.99% compared to head (ed5e707) 54.99%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #898   +/-   ##
=========================================
  Coverage     54.99%   54.99%           
  Complexity     1244     1244           
=========================================
  Files           133      133           
  Lines          8534     8534           
  Branches        789      789           
=========================================
  Hits           4693     4693           
  Misses         3425     3425           
  Partials        416      416           
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (ø)
RocketMQ Store 73.65% <0.00%> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
...com/automq/rocketmq/store/MessageStoreBuilder.java 0.00% <0.00%> (ø)
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <0.00%> (ø)

@Chillax-0v0 Chillax-0v0 merged commit 4192785 into main Jan 18, 2024
6 of 7 checks passed
@Chillax-0v0 Chillax-0v0 deleted the refactor-s3-operator-credentail-provider branch January 18, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants