Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: intrdouce spotbugs for s3stream, and reslove all the P1 issues #902

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

daniel-y
Copy link
Contributor

No description provided.

@daniel-y daniel-y requested a review from superhx January 25, 2024 06:04
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffdc0de) 55.01% compared to head (7d960b6) 55.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #902      +/-   ##
============================================
+ Coverage     55.01%   55.92%   +0.91%     
- Complexity     1246     1267      +21     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4695     4773      +78     
+ Misses         3425     3327      -98     
- Partials        414      434      +20     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (+2.80%) ⬆️
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.60% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 16 files with indirect coverage changes

@superhx superhx merged commit a5e1c0f into main Jan 25, 2024
7 checks passed
@superhx superhx deleted the introduce_spotbugs branch January 25, 2024 06:22
lifepuzzlefun pushed a commit to lifepuzzlefun/automq-for-rocketmq that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants