Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(s3stream): remove _total suffix for counter metrics #921

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Feb 5, 2024

leave the suffix to OTLP backend implementation

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b656c0e) 55.90% compared to head (5597682) 55.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #921      +/-   ##
============================================
+ Coverage     55.90%   55.94%   +0.03%     
- Complexity     1264     1267       +3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4771     4774       +3     
  Misses         3327     3327              
+ Partials        436      433       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@SCNieh SCNieh merged commit 7c35c31 into main Feb 5, 2024
7 checks passed
@SCNieh SCNieh deleted the metric_name branch February 5, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants