Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry to read/write/flush when IOException occurs #933

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

@Chillax-0v0 Chillax-0v0 added bug Something isn't working s3stream wal the WAL of S3 stream labels Feb 19, 2024
@Chillax-0v0 Chillax-0v0 self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (498690b) 55.92% compared to head (2e1e14b) 55.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #933      +/-   ##
============================================
- Coverage     55.92%   55.90%   -0.03%     
+ Complexity     1267     1264       -3     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
- Hits           4773     4771       -2     
  Misses         3327     3327              
- Partials        434      436       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.18% <ø> (-0.11%) ⬇️
RocketMQ Store 73.60% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx
Copy link
Contributor

superhx commented Feb 19, 2024

Be careful not to retry the detection operation indefinitely.

@Chillax-0v0 Chillax-0v0 merged commit 717c58b into main Feb 20, 2024
7 checks passed
@Chillax-0v0 Chillax-0v0 deleted the fix-s3stream-handle-io-exception branch February 20, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s3stream wal the WAL of S3 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants