Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add percent progress to initializing status view #387

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jdcallet
Copy link
Contributor

@jdcallet jdcallet commented Feb 20, 2024

#296

This add 3 new columns to the status command: src_db_size. dst_db_size, and progress. Those columns show values when the status is initializing, if not they show as n/a.

@jdcallet jdcallet requested a review from vjeeva as a code owner February 20, 2024 01:43
Copy link

github-actions bot commented Feb 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jdcallet
Copy link
Contributor Author

have read the CLA Document and I hereby sign the CLA

@jdcallet
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@vjeeva vjeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a screenshot or something to show the columns and what it looks like?

@vjeeva vjeeva changed the title fix: add status for the initializing stage feat: add status for the initializing stage Feb 20, 2024
@jdcallet
Copy link
Contributor Author

This is how it looks for the initializing stage:

docker-compose_yml_—_pgbelt

And this it how it looks for other stage than initializing:
docker-compose_yml_—_pgbelt

@vjeeva
Copy link
Contributor

vjeeva commented Feb 21, 2024

That is freaking awesome thank you @jdcallet

@vjeeva vjeeva changed the title feat: add status for the initializing stage feat: add percent progress to initializing status view Feb 21, 2024
@vjeeva vjeeva merged commit 6139cfc into main Feb 21, 2024
4 checks passed
@vjeeva vjeeva deleted the add-initializing-status branch February 21, 2024 23:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants