Use negative lookahead to allow openssl_* functions #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vary_cache_on_function
method will disallow all functions containing the substringopen
. This is likely to prevent the user from creating functions that usefopen
,opendir
and similar. However it also prevents users from using all functions from theopenssl_*
family.Our use case is the following:
openssl_decrypt
to decrypt a userdata cookie and then we set the variant based on whether the current user has purchased a subscription or not.This PR adds a negative lookahead to allow the
openssl_*
functions insidevary_cache_on_function
.