feat: forms of "get rid off" -> "rid of" #685
Conversation
also "in particularly"
examples from github: - This is my last project (Automattic#12), library-monotasking operative system for the Hack machine written in the Jack language. Support bugs and requests. - COS is a operative system made with the COSMOS Kernel and written in C#, COS its literally the same than MS-DOS but written in C# and open-source.
|
A lot of these changes would be better implemented as macro calls in |
I'll turn this one into a draft while I have a go at moving these over... |
Is this what you're looking for? Note that it offers more suggestions per error now. Maybe we need a new macro that can handle inflected forms? I don't see another example that handles inflected forms or other kinds of variants to copy. I'll wait for feedback on this one before proceding with converting the others.
Previous implementation was in Automattic#685 along with other lints in `matcher.rs` now in `phrase_corrections.rs`
…orrections.rs` Previously part of PR Automattic#685 mixed with other changes all in `matcher.rs`
Moved from `matcher.rs` to `phrase_corrections.rs`. Was previously part of PR Automattic#685 with other lints.
…orrections.rs` Previously part of PR Automattic#685 mixed with other changes all in `matcher.rs`
This whole thing still confuses me. I won't be putting multiple features into a single PR again, even if they seem to be of the same type. Atomic is much more manageable if anything goes slightly wrong. This is the current status of each part, as best I can tell:
@elijah-potter If you can push/merge in your version of "far/way to many/much" and I submit "gotten rid off" - then let me know if anything else is still outstanding, and then we can get rid of this old broken PR. |
All inflected forms: get/gets/getting/got rid off
I can't think of any false positives.
There's a case for handling just "rid off" → "rid of" but there may be a higher chance of false positives there, and I'm not sure if it occurs very much without "get". Let me know.
Random examples from Github for testing:
Please bump axios version to get rid off npm warning # 624
Get rid off "Missing" count in table1 · Issue # 21
31 Mar 2024 — ... getting rid off of all the complexity of the different accesses method of API service providers. From the API service provider, it will get ...
22 Apr 2016 — For now we got rid off circular deps in model tree structure and it's API. The question is whether I should work more to make this graph ...
29 Jan 2016 — papped commented on Jan 30, 2016. Adding at as a runtime dependency gets rid off that error, but now it comes back with the error: java.lang ...