feat: "news" used as plural

[hippietrail]

Addresses #407

Because of many lower/upper case variants this and similar might be better as a dedicated lint - or matcher.rs could be changed to handle case variants

[hippietrail]

Turning into a draft so this doesn't get merged before I fix it. I didn't think of the false positive "Back in the days of ..." but too busy to switch branches.

[elijah-potter]

I love the additions. Would you mind making them "real" rules in phrase_corrections?

For example:

create_linter_map_phrase!(
    News,
    ExactPhrase::from_phrase("many news are"), // Source pattern is mapped to the 
    "a lot of news is", // target string
    "MESSAGE",
    "DESCRIPTION"
);

If you'd like to go a bit further, you can optionally use the merge_linters macro to then merge them together.

[hippietrail]

I love the additions. Would you mind making them "real" rules in phrase_corrections?

For example:

create_linter_map_phrase!(
    News,
    ExactPhrase::from_phrase("many news are"), // Source pattern is mapped to the 
    "a lot of news is", // target string
    "MESSAGE",
    "DESCRIPTION"
);

If you'd like to go a bit further, you can optionally use the merge_linters macro to then merge them together.

On a tangent, why does this code ...

create_linter_map_phrase!(LoAndBehold, ExactPhrase::from_phrase("long and behold"), "lo and behold", "Did you mean `lo and behold`?", "Detects the exact phrase `long and behold` and suggests replacing it with the idiomatically correct `lo and behold`");

...n ot trigger the precommit error for having the error in its description? I just had to change the description of the modal-of lint to not have should of in the description but here long and behold in the description does not cause a problem 🫤

[hippietrail]

I love the additions. Would you mind making them "real" rules in phrase_corrections?

I just put in a bunch of time on the plural news one and it turned out to be much more combinatorial and contextual than I expected. I think a dedicated linter will be needed for it:

how many news are shown → ✅how much / ✅how many
So many news are going on these days every time we turn on our TVs → ✅So much / ❌So many pieces of