Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #20 : comma spacing and #498 : Asian commas #891

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hippietrail
Copy link
Contributor

@hippietrail hippietrail commented Mar 12, 2025

Issues

#20 and #498

Description

Correct spaces around commas, only between two words.
Replace East Asian commas with English commas when the context is English.

How Has This Been Tested?

  • I added unit tests for every combination of space before, comma type, space after.
  • I added some real-world examples from GitHub.
  • I added a unit test to make sure it doesn't flag Asian commas in Asian text.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

Screenshot

image

@hippietrail hippietrail changed the title feat: Towards #498 : Asian commas feat: #20 : comma spacing and #498 : Asian commas Mar 21, 2025
@hippietrail hippietrail marked this pull request as ready for review March 22, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant