Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step to ask if the user has an existing store #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Nov 10, 2016

Adds a new step after returning from setting up WooCommerce. The positioning of this step is a little awkward - you'll see it if you "Install WooCommerce" then opt out of the WC wizard, or if we detect you already have WC installed.

screen shot 2016-11-10 at 3 24 47 pm

To test:

  • Check out this branch
  • Go through the business flow
  • Install WooCommerce, then opt-out of the WC wizard
  • OR go through the WC wizard, and click "back to dashboard" at the end (small grey text under the box)
  • You should return to this step, where you can select a store - selecting one automatically sends the store to the completed step event tracking, and takes you to the review.
  • Clicking No goes directly to the review.
  • Clicking Next also just takes you to the review, without sending an event, since you haven't selected anything.

@jessefriedman @johnHackworth @roccotripaldi @tyxla

@ryelle ryelle added this to the 1.6 milestone Nov 10, 2016
@ryelle ryelle self-assigned this Nov 10, 2016
@johnHackworth
Copy link
Contributor

Let's also ping @rickybanister for some opinions from a designer point of view 🎨

@rickybanister
Copy link

Could I get a quick walk through of this to better understand how it will flow?

It seems fine, but the relationship between the dropdown with the 'yes' option and the 'nope' being a button has me a little confused.

@ryelle
Copy link
Member Author

ryelle commented Nov 11, 2016

screen shot 2016-11-11 at 1 15 29 pm

The dropdown opens to show the options when clicked, following this which @jessefriedman mocked up. It moves to the next step as soon as an option is clicked.

Here's a screen recording of part of the flow, from setting up WooCommerce (I skipped the steps only to get to the end of this wizard faster), to the final review screen (the end of JPO).

@rickybanister
Copy link

Perhaps we could relabel 'nope' to something more like 'I don't need a store'. My issue was the order of reading—I'd forgotten the original question as I evaluated the dropdown and 'next' button so 'nope' felt non-sequitur by then.

@ryelle
Copy link
Member Author

ryelle commented Nov 11, 2016

You shouldn't see this unless you installed WooCommerce in the previous step. We could be repetitive and relabel Nope to "No I didn't have a store" or something?

@rickybanister
Copy link

You're right, but I'm still highly confused. Can I ask, what is the point of this step? Why did they just create a store if they previously had one? If our goal is to do some kind of migration or to just gather data, why wouldn't we put this question before they went off to install WooCommerce?

@tyxla
Copy link
Member

tyxla commented Nov 14, 2016

Can I ask, what is the point of this step?

Now that I've gone through that step, it's something that bugs me as well. Is the purpose of this step just to collect some data from the users? I also find it confusing from user's perspective to have this step after we've (probably) installed WooCommerce.

Other than that, it works as expected, nice work @ryelle.

A quick suggestion: I think it would it be useful if we have a text field displayed when the user selects "Other" - just so they can clarify which platform they're using.

@ryelle
Copy link
Member Author

ryelle commented Nov 14, 2016

Is the purpose of this step just to collect some data from the users?

Yeah, that's all we're doing here. I'm not sure if we're looking for the details if someone selects "other", but maybe @jessefriedman can say for sure.

I have an issue about the order of steps, #49, if you want to drop any feedback there too.

@ryelle ryelle removed their assignment Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants