Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the notice message and improves the button style #42628

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

valterlorran
Copy link
Contributor

Related to Automattic/wp-calypso#100895
Closes Automattic/wp-calypso#101616

Proposed changes:

  • Update the Import Page notice, improving the text to make it clear you can fully import a WordPress site or content from other platforms.
  • Updates the design of the button to make it look active; I added the primary style to it.
Captura de Tela 2025-03-20 às 17 24 08

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Automattic/wp-calypso#100895 (comment)

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this PR to your WoA site(p9o2xV-1r2-p2)
  • Navigate to /wp-admin/import.php
  • Check that you see the updated message and the button looks like active

@valterlorran valterlorran requested a review from a team March 20, 2025 20:28
@valterlorran valterlorran self-assigned this Mar 20, 2025
@valterlorran valterlorran added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 20, 2025
Copy link
Contributor

github-actions bot commented Mar 20, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/import-page-notice-text-and-style branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/import-page-notice-text-and-style

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

Copy link
Contributor

@gabrielcaires gabrielcaires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as described 👍

@valterlorran valterlorran merged commit 3b03886 into trunk Mar 24, 2025
66 of 67 checks passed
@valterlorran valterlorran deleted the update/import-page-notice-text-and-style branch March 24, 2025 12:31
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[mu wpcom Feature] Import Customizations [Package] Jetpack mu wpcom WordPress.com Features [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP-Admin Tools > Import: WPcom Importer banner prompts for non-WP sites, obscuring our built-in Migration Flow
2 participants