Social: Fix data store performance issues

[manzoorwanijk]

Fixes #42441

Supercedes #42442

This PR fixes the performance issues with social data store to fix the warnings for the same in WP 6.8.

The PR takes a different approach than #42442 to fix the root cause of the issue, which was that our selectors in the store returned the results like empty arrays [], the result for .map() and .filter(), which have different reference each time, thus causing the data being flagged as changed.

Proposed changes:

• Update the store selectors to use a constant empty array wherever needed to avoid creating an array with new reference each time.
• Wraps the dependent selectors with createSelector to have them changed only when the dependent data changes
• For some changes, where the manipulation was done inside useSelect, this PR moves that manipulation out of useSelect to avoid those warnings.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to connections management
• Confirm that you can add/update/delete connections
• Confirm that the changes reflect as expected
• Break a connection - for example, remove Jetpack from here for Facebook.
• Come back to connections management or reload the page
• If the connection test result doesn't return the broken status immediately, try marking that connections as shared.
• Confirm that the broken connections notice shows up in the editor
• Confirm that Social post UI works fine with custom message and custom media and SIG
• Schedule a few shares and wait for the list to update
• Confirm that the list updates correctly
• Confirm that you don't see the useSelect warnings anywhere related to social UIs

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/social/store-performance-issues branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/social/store-performance-issues

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 8 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/publicize-components/src/components/social-post-modal/preview-section.tsx	0/22 (0.00%)	0.00%	2 ❤️‍🩹
projects/js-packages/publicize-components/src/components/social-post-modal/scheduled-shares.tsx	0/18 (0.00%)	0.00%	2 ❤️‍🩹
projects/js-packages/publicize-components/src/social-store/selectors/connection-data.ts	30/44 (68.18%)	5.68%	2 ❤️‍🩹
projects/js-packages/publicize-components/src/components/services/services-list.tsx	12/12 (100.00%)	0.00%	0 💚
projects/js-packages/publicize-components/src/hooks/use-post-meta/index.js	19/20 (95.00%)	0.26%	0 💚

Full summary · PHP report · JS report