Forms: Fix source filtering in classic view for responses management

[ntsekouras]

Fixes #42599

Within simple and atomic sites, filtering form responses by the "All sources" dropdown menu does not filter correctly. There is no change to the results. This affects the classic wp-admin list.

Proposed changes:

In the wp-admin list we perform two queries that trigger the pre_get_posts hook. One is for the main list and the other is for the source dropdown filter. We need to explicitly check one unique parameter between the two queries to avoid filtering the dropdown query. The dropdown query is in get_all_parent_post_ids.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

no

Testing instructions:

1. Visit the forms responses management (/wp-admin/edit.php?post_type=feedback) and make sure you're in the classic view
2. Update a source filter
3. Observe the results and the source filter options are displayed as expected.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the forms/fix-admin-source-filter branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack forms/fix-admin-source-filter

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[ntsekouras]

In #41602 we made the post type hierarchical. I tried to understand why this change affected this check the fields was id=>parent too, but couldn't figure it out. @anton-vlasenko do you have any thoughts?

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report