-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility: move from Post Editor to Site Editor versions of Utilities #42652
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
Partially fixes #37713
The remaining changes are made in this Social PR: #42634
Proposed changes:
@wordpress/edit-post
to@wordpress/editor
. As we currently ensure compatibility down to WordPress 6.6, the utilities in question can now be used via@wordpress/editor
.wp.editPost.PluginPrePublishPanel is deprecated since version 6.6. Please use wp.editor.PluginPrePublishPanel instead.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
On a self-hosted test site on trunk, ensure script debug is enabled:
define( 'SCRIPT_DEBUG', true );
inwp-config.php
. On trunk you can test functionality, and in some cases you can test for the console warnings, for the below features:Newsletter:
/wp-admin/admin.php?page=jetpack#newsletter
.PluginSidebar
that relates toNewsletterMenu
.PluginPrePublishPanel
,PluginDocumentSettingPanel
, andPluginPostPublishPanel
here, so that is Newsletter panels in the sidebar pre and post publishing. I couldn't replicate console warnings, but we can check behaviour.Jetpack Plugin Sidebar:
PluginSidebar
and one forPluginSidebarMoreMenuItem
that relates toJetpackPluginSidebarSlot
.Premium Content Block:
Blaze:
PluginPostPublishPanel
warning for this one, but not every time.Payments Post Publish Panel:
Yoast Promo:
Jetpack AI Assistant:
On WoA, this is tricker to test as the console messages aren't very descriptive, so you can't see what may be causing them (opening up a post shows several for example both before and after the change - at least on my test sites). However you can apply the PR for both Jetpack and the Jetpack Mu WPcom plugin using the Jetpack Beta Tester.
On Simple it is the same as with WoA. However I found this easier to test as you can compare console warnings when opening a post before and after applying the changes - on my test site there were none after, and several before. For a sandboxed Simple site, apply the changes using the commands in the generated comment below. With Simple, Newsletter settings seem to be at Settings > Newsletter. And of course, you can't install Yoast ;)