-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object-cache-pro and variation of wp-simple-firewall to incompatible plugins #42654
base: trunk
Are you sure you want to change the base?
Conversation
…ble plugins * Added object-cache pro as it relies on Redis and causes fatals * Added variation of wp-simple-firewall that use icwp-wpsf.php as the file name
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes:
Testing instructions:
wp plugin install wp-simple-firewall --activate
/wp-admin/plugins.php
page and confirm that the Shield Security is disabled.object-cache-pro is a paid plugin and can't be tested unless having a copy: https://objectcache.pro/
Does this pull request change what data or activity we track or use?
No