Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tweet screenshot mechanism #46

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update tweet screenshot mechanism #46

wants to merge 4 commits into from

Conversation

eltongo
Copy link
Contributor

@eltongo eltongo commented Sep 9, 2021 •
edited
Loading

This PR updates the tweet screenshot mechanism to take a whole page screenshot (not exactly, read below) instead of a specific element, whose selector is prone to change.

This won't be a "whole page screenshot" as in it takes a screenshot of the body element instead, since taking a screenshot using page.screenshot({...}) causes a page reload in this case, for some reason.

Testing instructions

This PR also updates packages, so a npm install is in order before trying the steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eltongo @aidvu