[Guest List and Network Highlight] Add header #3755

mebarbosa · 2025-03-11T17:49:30Z

Description

This PR adds the header to the collection
Track header tapping event
Add subscribe button
Design: zfZ5UzmdLBk3k4CwaFIN3E-fi-3646_53376

Testing Instructions

With GUEST_LISTS_NETWORK_HIGHLIGHTS_REDESIGN ON
Open Discover
Scroll until you see the Guest list, Guest Curator or Network highlight collection
See that the collection shows a header only for the fist page ✅
Tap on the header
Ensure 🔵 Tracked: discover_list_collection_header_tapped, Properties: {"list_id":"ilst-name", ✅
Ensure the collection opens ✅ (same behavior as tapping on show all button)

Screenshots or Screencast

Regular device	Large font size	Landscape

Screen_recording_20250319_122915.webm

Checklist

If this is a user-facing change, I have added an entry in CHANGELOG.md
Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
I have considered whether it makes sense to add tests for my changes
All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previews
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

with different themes
with a landscape orientation
with the device set to have a large display and font size
for accessibility with TalkBack

wpmobilebot · 2025-03-11T17:52:02Z

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.

	App Name	📱 Mobile
	Build Type	debugProd
	Commit	`29c9dc7`
	Direct Download	`pocketcasts-app-prototype-build-pr3755-29c9dc7.apk`

📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.

	App Name	🚗 Automotive
	Build Type	debugProd
	Commit	`29c9dc7`
	Direct Download	`pocketcasts-automotive-prototype-build-pr3755-29c9dc7.apk`

📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.

	App Name	⌚ Wear
	Build Type	debugProd
	Commit	`29c9dc7`
	Direct Download	`pocketcasts-wear-prototype-build-pr3755-29c9dc7.apk`

wpmobilebot · 2025-03-11T17:53:32Z

Project manifest changes for app

The following changes in the app's merged AndroidManifest.xml file were detected (build variant: release):

--- ./build/reports/diff_manifest/app/release/base_manifest.txt	2025-03-25 13:56:33.583689010 +0000
+++ ./build/reports/diff_manifest/app/release/head_manifest.txt	2025-03-25 13:57:25.313624218 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="au.com.shiftyjelly.pocketcasts"
-    android:versionCode="9326"
-    android:versionName="7.85-rc-3" >
+    android:versionCode="9319"
+    android:versionName="7.84-rc-4" >
 
     <uses-sdk
         android:minSdkVersion="24"
@@ -968,25 +968,29 @@
                 android:resource="@xml/large_player_widget" />
         </receiver>
         <receiver
+            android:name="au.com.shiftyjelly.pocketcasts.sharing.ItemSharedReceiver"
+            android:exported="false" />
+
+        <provider
+            android:name="au.com.shiftyjelly.pocketcasts.repositories.playback.auto.AlbumArtContentProvider"
+            android:authorities="au.com.shiftyjelly.pocketcasts.media.library.provider"
+            android:exported="true" /> <!-- The widget can't move from the core package or it gets deleted when the new APK is installed -->
+        <receiver
             android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PodcastWidget"
             android:exported="true"
             android:label="@string/medium_player_classic_widget_label" >
             <intent-filter>
                 <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PREVIOUS" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.NEXT" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PLAY" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PAUSE" />
             </intent-filter>
 
             <meta-data
                 android:name="android.appwidget.provider"
-                android:resource="@xml/classic_player_widget" />
-        </receiver>
-        <receiver
-            android:name="au.com.shiftyjelly.pocketcasts.sharing.ItemSharedReceiver"
-            android:exported="false" />
-
-        <provider
-            android:name="au.com.shiftyjelly.pocketcasts.repositories.playback.auto.AlbumArtContentProvider"
-            android:authorities="au.com.shiftyjelly.pocketcasts.media.library.provider"
-            android:exported="true" /> <!-- Workers -->
+                android:resource="@xml/widget" />
+        </receiver> <!-- Workers -->
         <service
             android:name="androidx.work.impl.foreground.SystemForegroundService"
             android:directBootAware="false"

Go to https://buildkite.com/automattic/pocket-casts-android/builds/11221/canvas?sid=0195cd93-a6a3-4cbf-bfd7-0eeae6ce79c2, click on the Artifacts tab and audit the files.

wpmobilebot · 2025-03-11T17:54:05Z

Project manifest changes for wear

The following changes in the wear's merged AndroidManifest.xml file were detected (build variant: release):

--- ./build/reports/diff_manifest/wear/release/base_manifest.txt	2025-03-25 13:57:45.213618288 +0000
+++ ./build/reports/diff_manifest/wear/release/head_manifest.txt	2025-03-25 13:58:03.853601165 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="au.com.shiftyjelly.pocketcasts"
-    android:versionCode="9326"
-    android:versionName="7.85-rc-3" >
+    android:versionCode="9319"
+    android:versionName="7.84-rc-4" >
 
     <uses-sdk
         android:minSdkVersion="26"
@@ -244,8 +244,23 @@
         <provider
             android:name="au.com.shiftyjelly.pocketcasts.repositories.playback.auto.AlbumArtContentProvider"
             android:authorities="au.com.shiftyjelly.pocketcasts.media.library.provider"
-            android:exported="true" />
+            android:exported="true" /> <!-- The widget can't move from the core package or it gets deleted when the new APK is installed -->
+        <receiver
+            android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PodcastWidget"
+            android:exported="true"
+            android:label="@string/medium_player_classic_widget_label" >
+            <intent-filter>
+                <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PREVIOUS" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.NEXT" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PLAY" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PAUSE" />
+            </intent-filter>
 
+            <meta-data
+                android:name="android.appwidget.provider"
+                android:resource="@xml/widget" />
+        </receiver>
         <receiver
             android:name="com.google.android.gms.cast.framework.media.MediaIntentReceiver"
             android:exported="false" />

Go to https://buildkite.com/automattic/pocket-casts-android/builds/11221/canvas?sid=0195cd93-a6a3-4cbf-bfd7-0eeae6ce79c2, click on the Artifacts tab and audit the files.

wpmobilebot · 2025-03-11T17:54:30Z

Project manifest changes for automotive

The following changes in the automotive's merged AndroidManifest.xml file were detected (build variant: release):

--- ./build/reports/diff_manifest/automotive/release/base_manifest.txt	2025-03-25 13:58:20.483584122 +0000
+++ ./build/reports/diff_manifest/automotive/release/head_manifest.txt	2025-03-25 13:58:35.613569242 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="au.com.shiftyjelly.pocketcasts"
-    android:versionCode="9326"
-    android:versionName="7.85-rc-3" >
+    android:versionCode="9319"
+    android:versionName="7.84-rc-4" >
 
     <uses-sdk
         android:minSdkVersion="28"
@@ -216,7 +216,23 @@
         <provider
             android:name="au.com.shiftyjelly.pocketcasts.repositories.playback.auto.AlbumArtContentProvider"
             android:authorities="au.com.shiftyjelly.pocketcasts.media.library.provider"
-            android:exported="true" /> <!-- Workers -->
+            android:exported="true" /> <!-- The widget can't move from the core package or it gets deleted when the new APK is installed -->
+        <receiver
+            android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PodcastWidget"
+            android:exported="true"
+            android:label="@string/medium_player_classic_widget_label" >
+            <intent-filter>
+                <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PREVIOUS" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.NEXT" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PLAY" />
+                <action android:name="au.com.shiftyjelly.pocketcasts.core.ui.widget.PAUSE" />
+            </intent-filter>
+
+            <meta-data
+                android:name="android.appwidget.provider"
+                android:resource="@xml/widget" />
+        </receiver> <!-- Workers -->
         <service
             android:name="androidx.work.impl.foreground.SystemForegroundService"
             android:directBootAware="false"

Go to https://buildkite.com/automattic/pocket-casts-android/builds/11221/canvas?sid=0195cd93-a6a3-4cbf-bfd7-0eeae6ce79c2, click on the Artifacts tab and audit the files.

geekygecko

Is it possible to get the following closer to the design:

The drop shadows are being cut off.
Can the subtitle have some more horizontal padding.
Can the two podcasts title and author be cut off similar to the design rather than wrapped?

modules/features/discover/src/main/res/layout/collection_header.xml

...cover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/CollectionListRowAdapter.kt

mebarbosa · 2025-03-12T13:44:28Z

Hey @geekygecko I addressed all comments for this PR.

Can the two podcasts title and author be cut off similar to the design rather than wrapped?

Regarding to this one, I asked about this here p1741786537792849/1741720182.869959-slack-C08HC6RUH40

wpmobilebot · 2025-03-17T13:00:56Z

Version 7.85 has now entered code-freeze, so the milestone of this PR has been updated to 7.86.

geekygecko · 2025-03-18T22:38:30Z

How's this change going? Is matching the design tricky?

geekygecko · 2025-03-21T00:44:22Z

Did you see my message above? Is this PR ready to review?

mebarbosa · 2025-03-21T13:28:06Z

@geekygecko Sorry. I miss the notification for this PR. Yes, it's ready for review

geekygecko · 2025-03-25T05:26:27Z

The new paging is great!

The only minor issues are:

The drop shadow on white artwork doesn't look right.
@david-gonzalez-a8c there is quite a bit of padding between the artwork and the paging dots when compared with the featured component. Is this correct?

mebarbosa added 7 commits March 10, 2025 09:42

set width size for podcast

8ad55fe

truncate after 2 lines for the title and 1 line for the subtitle

6ebde7e

add header for collection

8510be0

open collection when tapping on header

d819584

set content description for header

9358047

display the first two podcasts in the next page as well

3172f0c

improve code

dfea485

mebarbosa added [Type] Enhancement Improve an existing feature. [Project] Guest list and Network highlight changes labels Mar 11, 2025

mebarbosa added this to the 7.85 milestone Mar 11, 2025

mebarbosa requested a review from a team as a code owner March 11, 2025 17:49

mebarbosa requested review from geekygecko and removed request for a team March 11, 2025 17:49

add subscribe button

3ceb22c

geekygecko reviewed Mar 12, 2025

View reviewed changes

modules/features/discover/src/main/res/layout/collection_header.xml Outdated Show resolved Hide resolved

modules/features/discover/src/main/res/layout/collection_header.xml Outdated Show resolved Hide resolved

geekygecko reviewed Mar 12, 2025

View reviewed changes

...cover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/CollectionListRowAdapter.kt Outdated Show resolved Hide resolved

geekygecko reviewed Mar 12, 2025

View reviewed changes

...cover/src/main/java/au/com/shiftyjelly/pocketcasts/discover/view/CollectionListRowAdapter.kt Outdated Show resolved Hide resolved

mebarbosa added 5 commits March 12, 2025 08:55

simplify content description

2bb6cf6

fix header placeholder image

07e7c43

add more paddings

e00d90a

add comment for getting height

3c8f913

simplify header layout

45fc8bb

mebarbosa requested a review from geekygecko March 12, 2025 13:43

preview next page

2241a46

wpmobilebot removed this from the 7.85 milestone Mar 17, 2025

wpmobilebot added this to the 7.86 milestone Mar 17, 2025

mebarbosa added 3 commits March 19, 2025 12:26

improve page preview

a52f30a

rename view holders

58217ca

hide header in page 1

d071080

set max line 2 for both title and subtitle

5e40ec4

fix drop shadow being cut off

29c9dc7

geekygecko approved these changes Mar 25, 2025

View reviewed changes

geekygecko merged commit abeef4a into main Mar 25, 2025
17 checks passed

geekygecko deleted the task/add-header-to-discover-collection branch March 25, 2025 22:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Guest List and Network Highlight] Add header #3755

[Guest List and Network Highlight] Add header #3755

mebarbosa commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

geekygecko left a comment

mebarbosa commented Mar 12, 2025

wpmobilebot commented Mar 17, 2025

geekygecko commented Mar 18, 2025

geekygecko commented Mar 21, 2025

mebarbosa commented Mar 21, 2025

geekygecko commented Mar 25, 2025

[Guest List and Network Highlight] Add header #3755

[Guest List and Network Highlight] Add header #3755

Conversation

mebarbosa commented Mar 11, 2025 • edited Loading

Description

Testing Instructions

Screenshots or Screencast

Checklist

I have tested any UI changes...

wpmobilebot commented Mar 11, 2025 • edited Loading

wpmobilebot commented Mar 11, 2025 • edited Loading

Project manifest changes for app

wpmobilebot commented Mar 11, 2025 • edited Loading

Project manifest changes for wear

wpmobilebot commented Mar 11, 2025 • edited Loading

Project manifest changes for automotive

geekygecko left a comment

Choose a reason for hiding this comment

mebarbosa commented Mar 12, 2025

wpmobilebot commented Mar 17, 2025

geekygecko commented Mar 18, 2025

geekygecko commented Mar 21, 2025

mebarbosa commented Mar 21, 2025

geekygecko commented Mar 25, 2025

mebarbosa commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading

wpmobilebot commented Mar 11, 2025 •

edited

Loading