-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the use of the AutoDownloadStatus enums #2506
base: trunk
Are you sure you want to change the base?
Conversation
Use the enum directly on the model type and avoid the uses of raw value and casting in the codebase. I also found that FMDatabase can support the use of Enum directly on their statements if they are a base type. Ex: Int32, Int, etc..
Version |
Version |
Version |
Version |
Version |
Version |
Version |
| 📘 Part of: # |
|:---:|
Fixes #
On this PR we use the enum directly on the model type and avoid the uses of raw value and casting in the codebase. I also found that FMDatabase can support the use of Enum directly on their statements if they are a base type. Ex: Int32, Int, etc..
One of the things that was blocking it was that our base episode protocol was marked as ObjC. I thought there was some reason for the use of
@objc
tag on the protocols, but after removal I didn't get any kind of error.If someone knows the reason why those protocols are marked @objc please comment bellow.
To test
Checklist
CHANGELOG.md
if necessary.