-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chapters] Parse toc and modify index #2807
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the PR test steps and all is working correctly:
- Only toc chapters were visible
- None was deselected because toc hidden chapters were deselected on the original branch
# Conflicts: # Modules/Utils/Sources/PocketCastsUtils/Feature Flags/FeatureFlag.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielebogo chapters are not skipping as they should. Here's the test I did:
- Went on
develop
and deselected some chapters - Ran this branch/app
- Tap play
- Once the chapter "Fire by climate" finishes I expected "New uniform" to play. It didn't, it just ket playing, as you can see below:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-11.at.16.44.53.mp4
Version |
This PR introduces filtering out chapters that should not be in the table of contents. See the specification for more details.
The implementation relies on splitting real index and UI index. Real index is stored and is always used for syncing pre-selected chapters. While UI index is computed on-the-fly after we filter out all invalid chapters, etc.
In the database migration I had to delete all cached remote chapters as we don't have information whether such chapters should be displayed or not.
To test
main
branch.X sats from Y
.task/chaptes-toc
branch.X sats from Y
chapters and no chapters got de-selected.Checklist
CHANGELOG.md
if necessary.