Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggested Folders] - Fix upsell flow #2883

Merged

Conversation

SergioEstevao
Copy link
Contributor

| 📘 Part of: # |
|:---:|

Fixes #

Ensure that suggested folders up sell show, shows purchase details screen before login

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-03-21.at.13.34.03.mp4

To test

  1. Start the app with no logged in user
  2. Go to podcasts tab
  3. Tap on Folders
  4. Check that you see the Suggested Folder screen
  5. Tap on Replace Folders or Create Custom Folder
  6. Check that you see the upsell folders screen instead of the login screen
  7. Tap on Start Free Trial
  8. Check that you see the login/signup screen

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added this to the 7.85 ❄️ milestone Mar 21, 2025
@SergioEstevao SergioEstevao requested a review from a team as a code owner March 21, 2025 13:34
@SergioEstevao SergioEstevao requested review from danielebogo and removed request for a team March 21, 2025 13:34
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.85 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
Worked as described

@SergioEstevao SergioEstevao merged commit dd6697b into release/7.85 Mar 21, 2025
5 of 8 checks passed
@SergioEstevao SergioEstevao deleted the sergio/fix_suggested_folders_upsell_flow branch March 21, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants