Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Deliverfile in favor of Fastfile #1084

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Deprecate Deliverfile in favor of Fastfile #1084

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de1e01
Deprecate `Deliverfile` in favor of `Fastfile`
iangmaia Feb 6, 2023
52e90be
Update the bump version call to reflect that we no longer use the Del…
iangmaia Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions fastlane/Deliverfile
View file
Open in desktop

This file was deleted.

26 changes: 26 additions & 0 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ INTERNAL_SCHEME = 'Simplenote'
APP_STORE_SCHEME = 'Simplenote-AppStore'
BUILD_FOLDER = 'build'
APP_STORE_CONNECT_API_KEY_PATH = File.join(Dir.home, '.configure', 'simplenote-macos', 'secrets', 'app_store_connect_fastlane_api_key.json')
APP_STORE_BUNDLE_IDENTIFIER = 'com.automattic.SimplenoteMac'

# On CI, it's useful to skip code signing unless necessary to avoid spending
# time syncing the certificates and profiles with match. And while not
Expand Down Expand Up @@ -366,6 +367,31 @@ end
end
end

# Upload the localized metadata (from `fastlane/metadata/`) to App Store Connect
#
# @option [Boolean] with_screenshots (default: false) If true, will also upload the latest screenshot files to ASC
#
desc 'Upload the localized metadata to App Store Connect, optionally including screenshots.'
lane :update_metadata_on_app_store_connect do |options|
# Skip screenshots by default. The naming is "with" to make it clear that
# callers need to opt-in to adding screenshots. The naming of the deliver
# (upload_to_app_store) parameter, on the other hand, uses the skip verb.
with_screenshots = options.fetch(:with_screenshots, false)
skip_screenshots = !with_screenshots

upload_to_app_store(
app_identifier: APP_STORE_BUNDLE_IDENTIFIER,
app_version: ios_get_app_version,
skip_binary_upload: true,
screenshots_path: './screenshots/',
skip_screenshots: skip_screenshots,
overwrite_screenshots: true, # won't have effect if `skip_screenshots` is true
phased_release: true,
precheck_include_in_app_purchases: false,
api_key_path: APP_STORE_CONNECT_API_KEY_PATH
)
end

# Temporary lane to automate the process of uploading the .app manually
# exported after archiving the Simplenote scheme from Xcode.
#
Expand Down
1 change: 1 addition & 0 deletions fastlane/metadata/copyright.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2023 Automattic
1 change: 1 addition & 0 deletions fastlane/metadata/default/privacy_url.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://simplenote.com/privacy/