Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dangermattic configuration #1135

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add Dangermattic configuration #1135

merged 3 commits into from
Feb 21, 2024

Conversation

iangmaia
Copy link
Contributor

Fix

This PR adds Dangermattic to this repo. My main goal was to add RuboCop, but I've also used the same Dangermattic checks as in WordPress iOS, as per the old Peril configuration.

Test

The main validation is to make sure CI is 🟢.

To run Danger yourself:

  1. Checkout this branch
  2. Run bundle install
  3. Run:
DANGER_GITHUB_API_TOKEN=<github_token> bundle exec danger pr <PR_URL>

You should get in the console the same errors / warnings reported in the PR.

Release

These changes do not require release notes.

@iangmaia iangmaia added the tooling Related to anything that supports the building & maintaining of the project. label Feb 20, 2024
@iangmaia iangmaia requested a review from mokagio February 20, 2024 19:06
@iangmaia iangmaia self-assigned this Feb 20, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see most/all of the RuboCop violations had already been taken care of.

@iangmaia iangmaia merged commit 747ef11 into trunk Feb 21, 2024
6 of 7 checks passed
@iangmaia iangmaia deleted the iangmaia/dangermattic-setup branch February 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants