Update SwiftLint configuration in the project and run it on CI #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
iangmaia
changed the title
iangmaia
changed the title
Generated by 🚫 Danger |
mokagio
approved these changes
Feb 27, 2024
| rescue StandardError | ||
| exit $CHILD_STATUS.exitstatus | ||
| end | ||
|
|
There was a problem hiding this comment.
I'm guessing the rationale for removing the pre-commit hook is that SwiftLint should be running as part of the build now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up SwiftLint as CocoaPods dependency and runs it on CI using the command
run-swiftlint.The main changes:
.swiftlint.ymlfile update and definition of the SwiftLint version to use.run-swiftlintcommand froma8c-ci-toolkit-buildkite-pluginin a new Buildkite step.Testing Details
Make sure CI is 🟢